Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Github Workflow #2076

Merged
merged 7 commits into from
Aug 28, 2019
Merged

Added Github Workflow #2076

merged 7 commits into from
Aug 28, 2019

Conversation

fearphage
Copy link
Member

Using UI this time since CLI doesn't seem to work.

This replaces #1990.

Using UI since CLI doesn't seem to work
@coveralls
Copy link

coveralls commented Aug 20, 2019

Pull Request Test Coverage Report for Build 2965

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.203%

Totals Coverage Status
Change from base Build 2939: 0.0%
Covered Lines: 1666
Relevant Lines: 1735

💛 - Coveralls

@fatso83 fatso83 marked this pull request as ready for review August 20, 2019 20:22
@fatso83
Copy link
Contributor

fatso83 commented Aug 20, 2019

Eh, I didn't mean to do that (change from draft to ready). #bigthumbs

Anyway, this looks fine (maybe not run on Node 6). How can we tell if it works before merging?

trying 'npm ci' again
@fearphage
Copy link
Member Author

Anyway, this looks fine (maybe not run on Node 6).

Removed.

How can we tell if it works before merging?

image

One thing of note is it's not running npm run test-cloud. I believe it needs some extra setup (secrets) that we can add later.

Copy link
Member

@mroderick mroderick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! 👍

@fearphage fearphage mentioned this pull request Aug 21, 2019
@mroderick
Copy link
Member

One thing of note is it's not running npm run test-cloud. I believe it needs some extra setup (secrets) that we can add later.

I don't think we can run that on anything other than master, so that shouldn't stop us from moving forwards.

How about adding the coveralls integration (or switching to codecov like in @sinonjs/referee)?

.github/workflows/main.yml Outdated Show resolved Hide resolved
@fearphage
Copy link
Member Author

I'm done now.

It does everything, but npm run test-cloud on master. I could add that with some assistance (settings changes).

Copy link
Contributor

@mgred mgred left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@fearphage fearphage merged commit 766cae4 into master Aug 28, 2019
@fearphage fearphage deleted the github-workflow branch August 28, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants